Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow duplication of charts in layouting step #1770

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Sep 27, 2024

Closes #1769

This PR allows duplication of charts in the layouting step. What still could be improved is to maintain the size of the duplicated chart in the layout mode, now it initializes in "initial" size and adjusts the height like a new chart.

How to reproduce

See #1769

How to test

  1. Go to this link.
  2. Proceed to layout options.
  3. ✅ See that it's possible to duplicate charts using any layout.

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 3:05pm

Copy link
Contributor

@noahonyejese noahonyejese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 🎉

@bprusinowski bprusinowski merged commit d6a6ad5 into main Sep 27, 2024
5 of 6 checks passed
@bprusinowski bprusinowski deleted the fix/duplicating-charts-in-layouting-step branch September 27, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✅ Dashboard Layout: Duplicating charts does not work
2 participants